update citations to include new JOSS paper #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikofski
approved these changes
Sep 11, 2018
Member
mikofski
left a comment
mikofski
left a comment
There was a problem hiding this comment.
Thanks for letting me be part of this amazing project.
Member
Author
|
@cwhanse let me know if you'd like to see any additional changes to the citation recommendations. |
Member
|
@wholmgren looks good to me. It is a big improvement to have the JOSS paper as the preferred reference, rather than randomly pointing at one of the conference papers. I'm at a bifacial workshop and have heard a lot of positive feedback about pvlib. Motivated to pick up #421 again. |
Member
Author
|
@cwhanse thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update citations for new JOSS paper. @mikofski @cwhanse