fix incorrect nan assignments in singleaxis, allow scalar and 1d array input #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![stickler-ci[bot]](https://avatars.githubusercontent.com/in/15299?s=60&v=4){kind=small}
pvlib/test/test_tracking.py
Outdated
| expect = pd.DataFrame({'tracker_theta': 0, 'aoi': 10, | ||
| 'surface_azimuth': 90, 'surface_tilt': 0}, | ||
| index=[0], dtype=np.float64) | ||
| index=index, dtype=np.float64) |
There was a problem hiding this comment.
E127 continuation line over-indented for visual indent
pvlib/test/test_tracking.py
Outdated
| apparent_azimuth = np.array([[180, 180], [180, 180]]) | ||
| with pytest.raises(ValueError): | ||
| tracker_data = tracking.singleaxis(apparent_zenith, apparent_azimuth, | ||
| axis_tilt=0, axis_azimuth=0, |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
pvlib/test/test_tracking.py
Outdated
| with pytest.raises(ValueError): | ||
| tracker_data = tracking.singleaxis(apparent_zenith, apparent_azimuth, | ||
| axis_tilt=0, axis_azimuth=0, | ||
| max_angle=90, backtrack=True, |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
pvlib/test/test_tracking.py
Outdated
| tracker_data = tracking.singleaxis(apparent_zenith, apparent_azimuth, | ||
| axis_tilt=0, axis_azimuth=0, | ||
| max_angle=90, backtrack=True, | ||
| gcr=2.0/7.0) |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
wholmgren
changed the title
wholmgren
commented
Sep 11, 2018
cwhanse
approved these changes
Sep 12, 2018
pvlib/tracking.py
Outdated
| # filter for sun above panel horizon | ||
| wid[zp <= 0] = np.nan | ||
| zen_gt_90 = apparent_zenith > 90 | ||
| wid[apparent_zenith > 90] = np.nan |
Member
There was a problem hiding this comment.
did you mean wid[zen_gt_90] = np.nan?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.I punted on the question of nan/0.
Would also be nice to remove the requirement that input data be series. Yuck.Now accepts scalar/1d input