fix python 3.7 build on travis #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
approved these changes
Dec 12, 2018
Closed
mabounassif
pushed a commit
to mabounassif/pvlib-python
that referenced
this pull request
Feb 7, 2020
* update try python 3.7 * 3.7dev * new resize operation * whats new, comment
mabounassif
pushed a commit
to mabounassif/pvlib-python
that referenced
this pull request
Feb 7, 2020
* update try python 3.7 * 3.7dev * new resize operation * whats new, comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.We've been seeing issues with the
spa.pyfile on the Python 3.7 build on Travis for a few months. The error is related to resizing some arrays in place. For some reason, this works fine on Python 2.7 - 3.6 and but fails on some platforms on 3.7. I could never reproduce it locally on my mac or linux machines. This PR takes a different approach to resizing the arrays.Worked on my fork, hopefully works in this PR...