Skip to content

Conversation

@cwhanse
Copy link
Member

@cwhanse cwhanse commented Jun 25, 2019

  • Closes Update test_psm3.csv #733
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above): NSRDB change in 6/2019 move timestamps to the midpoint of each hour, e.g., 1230 for the hour between 1200 and 1300. This change adjusts the timestamps in the fixed data file test_psm3.csv.

Copy link
Member

@mikofski mikofski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wholmgren wholmgren added this to the 0.7.0 milestone Jul 10, 2019
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwhanse merge if ready.

@cwhanse cwhanse merged commit e3635c2 into pvlib:master Jul 10, 2019
@cwhanse cwhanse deleted the psm3 branch October 2, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update test_psm3.csv

3 participants