detrend patch for compat with scipy welch default #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwstegman
reviewed
Nov 19, 2024
Owner
pwstegman
left a comment
pwstegman
left a comment
There was a problem hiding this comment.
Thank you so much for contributing! I appreciate you catching and adding this! I added some comments to the PR, let me know what you think
| import { windowApply } from '../data/windowApply'; | ||
| import { nextpow2 } from './nextpow2'; | ||
|
|
||
| const d_mean = (arr) => arr.reduce((a, b) => a + b, 0) / arr.length; |
Owner
There was a problem hiding this comment.
Nice! Can you add a corresponding unit test to cover this logic in test/tests/shared/math/welch.test.js? Maybe something like a copy of the existing unit test but we add a very obvious upward trend to the input
Author
There was a problem hiding this comment.
Sent a fresh pull request with default 'none'
Author
There was a problem hiding this comment.
Will work on the test part in Dec once I get some time pl ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most people expect results for welch to match scipy welch default which applies constant detrend. I have patched the same here.