Compatibility: use pytest instead of nose - #408
Draft
antirotor wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
There are also two tests failing (one silently), not related most likely to switch to pytest: tests/test_plugin::test_argumentless_explitic_plugin (seems like for Instance plugin, the check for arguments doesn't work? |
Member
|
I've added an alternative solution here, that doesn't require a change of framework with more (many more!) dependencies. pytest not only pulls in tons of dependencies, but some of those dependencies are compiled for the platform as well, making it difficult to vendor. Have a look and see if it fits. |
Contributor
Author
|
I've separated #410 from this as it is the real blocker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using long unmaintained and abandoned nose for running tests started finally breaking with python 3.11 and higher. This PR is fixing two issues:
iscompatible.pybreaking on python 3.12 because warnings became SyntaxErrorsnosetopytest(some cleanup still pending and dependency handling delegated touvuv