sofar: add Sofa.convention_status
#124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-brinkmann
force-pushed
the
feature/convention_status
branch
from
9be68a3 to
e4f8db9
Compare
f-brinkmann
force-pushed
the
feature/convention_status
branch
from
e4f8db9 to
b045cef
Compare
f-brinkmann
commented
Apr 21, 2025
| f"- GLOBAL_SOFAConventions is " | ||
| f"{self.GLOBAL_SOFAConventions}, which is deprecated. Use " | ||
| "Sofa.upgrade_convention() to upgrade to " | ||
| f"{deprecations['GLOBAL:SOFAConventions'][convention]}") |
Member
Author
There was a problem hiding this comment.
This part of the error message failed in case a conventio is deprecated but a later version of the same convnetion is available. Simplified the error message to work in all cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Sofa.convention_status. I hope this makes the state of SOFA conventions andSOFA.verifymore clear.