Skip to content

Conversation

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Oct 18, 2025

Type of Changes

Type
🐛 Bug fix

Description

Closes #10652

@jacobtylerwalls jacobtylerwalls added this to the 4.0.2 milestone Oct 18, 2025
@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code C: invalid-name backport maintenance/4.0.x labels Oct 18, 2025
@jacobtylerwalls jacobtylerwalls changed the title [WIP] [WIP] Fix FP for invalid-name for partially invalid module-level name Oct 18, 2025
@jacobtylerwalls jacobtylerwalls force-pushed the jtw/partially-uninferable branch from 5d62daf to 5ef02fa Compare October 19, 2025 14:12
@jacobtylerwalls jacobtylerwalls changed the title [WIP] Fix FP for invalid-name for partially invalid module-level name Fix FP for invalid-name for partially invalid module-level name Oct 19, 2025
@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review October 19, 2025 14:12
@jacobtylerwalls jacobtylerwalls force-pushed the jtw/partially-uninferable branch from 5ef02fa to 4d16c94 Compare October 19, 2025 14:34
@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.97%. Comparing base (6678c90) to head (27406f5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10678   +/-   ##
=======================================
  Coverage   95.96%   95.97%           
=======================================
  Files         176      176           
  Lines       19526    19529    +3     
=======================================
+ Hits        18739    18742    +3     
  Misses        787      787           
Files with missing lines Coverage Δ
pylint/checkers/base/name_checker/checker.py 98.73% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on home-assistant:
The following messages are no longer emitted:

  1. invalid-name:
    Variable name "DEFAULT_TIME_ZONE" doesn't conform to snake_case naming style
    https://github.com/home-assistant/core/blob/81572c6a84a8d16e2a25503a48659e08da0d2a5a/homeassistant/util/dt.py#L20
  2. invalid-name:
    Variable name "ENTITY_DESCRIPTIONS" doesn't conform to snake_case naming style
    https://github.com/home-assistant/core/blob/81572c6a84a8d16e2a25503a48659e08da0d2a5a/homeassistant/components/unifi/sensor.py#L375

Effect on pandas:
The following messages are no longer emitted:

  1. invalid-name:
    Variable name "_USE_BOTTLENECK" doesn't conform to snake_case naming style
    https://github.com/pandas-dev/pandas/blob/a329dc353adf9fea2a85ef57dce7201ddf5ef684/pandas/core/nanops.py#L56
  2. invalid-name:
    Variable name "GLOBAL_USE_NUMBA" doesn't conform to snake_case naming style
    https://github.com/pandas-dev/pandas/blob/a329dc353adf9fea2a85ef57dce7201ddf5ef684/pandas/core/util/numba_.py#L17
  3. invalid-name:
    Variable name "_TEST_MODE" doesn't conform to snake_case naming style
    https://github.com/pandas-dev/pandas/blob/a329dc353adf9fea2a85ef57dce7201ddf5ef684/pandas/core/computation/expressions.py#L30

Effect on sentry:
The following messages are no longer emitted:

  1. invalid-name:
    Variable name "VERSION" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/__init__.py#L11
  2. invalid-name:
    Variable name "TASKWORKER_SCHEDULES" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/conf/server.py#L1155
  3. invalid-name:
    Variable name "TASKWORKER_SCHEDULES" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/conf/server.py#L1157
  4. invalid-name:
    Variable name "SENTRY_WEB_HOST" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/conf/server.py#L1421
  5. invalid-name:
    Variable name "SENTRY_SUBNET_SECRET" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/conf/server.py#L3158
  6. invalid-name:
    Variable name "SENTRY_CONTROL_ADDRESS" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/conf/server.py#L3161
  7. invalid-name:
    Variable name "EVENT_PAYLOAD_SCHEMA" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/issues/json_schemas.py#L176
  8. invalid-name:
    Variable name "RESULT_TYPES" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/search/events/constants.py#L142
  9. invalid-name:
    Variable name "ALLOWED_GRANULARITIES" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/snuba/metrics_layer/query.py#L50
  10. invalid-name:
    Variable name "RAW_SOCKET_PATH" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/b1c77654fe667f83fb4eb1ccfc677d02636984e3/src/sentry/runner/commands/devservices.py#L24

Effect on coverage:
The following messages are no longer emitted:

  1. invalid-name:
    Variable name "_UNINTERESTING_GLOBALS" doesn't conform to snake_case naming style
    https://github.com/nedbat/coveragepy/blob/9c2960e168550acbfab93cb99c82dd3c9debe737/coverage/env.py#L17
  2. invalid-name:
    Variable name "YIELD_FROM" doesn't conform to snake_case naming style
    https://github.com/nedbat/coveragepy/blob/9c2960e168550acbfab93cb99c82dd3c9debe737/coverage/pytracer.py#L47
  3. invalid-name:
    Variable name "RELATIVE_DIR" doesn't conform to snake_case naming style
    https://github.com/nedbat/coveragepy/blob/9c2960e168550acbfab93cb99c82dd3c9debe737/coverage/files.py#L25

This comment was generated for commit 27406f5

@jacobtylerwalls jacobtylerwalls merged commit 7ecfd9f into pylint-dev:main Oct 19, 2025
44 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/partially-uninferable branch October 19, 2025 15:55
pylint-backport bot pushed a commit that referenced this pull request Oct 19, 2025
jacobtylerwalls added a commit that referenced this pull request Oct 19, 2025
…uninferable module-level name (#10687)

Fix FP for `invalid-name` for partially uninferable module-level name (#10678)

(cherry picked from commit 7ecfd9f)

Co-authored-by: Jacob Walls <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport maintenance/4.0.x C: invalid-name False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid-name match for a valid name in except

2 participants