Fix a false positive for unbalanced-tuple-unpacking.
#10724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦is assigned to a function call and the structure of the function's return value is ambiguous. Closes pylint-dev#10721
mbyrnepr2
changed the title
unbalanced-tuple-unpacking when a tuple β¦unbalanced-tuple-unpacking.
This comment has been minimized.
This comment has been minimized.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10724 +/- ##
=======================================
Coverage ? 95.98%
=======================================
Files ? 176
Lines ? 19537
Branches ? 0
=======================================
Hits ? 18752
Misses ? 785
Partials ? 0
π New features to boost your workflow:
|
Pierre-Sassoulas
added
False Positive π¦
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
LGTM, just curious about what is happening when it should raise and maybe comment that it's a known false negative. (because there's a constraint for None now in astroid, maybe we can do it?)
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
approved these changes
Nov 8, 2025
Contributor
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit f4bf17a |
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
pylint-backport bot
pushed a commit
that referenced
this pull request
Nov 8, 2025
* Fix a false positive for ``unbalanced-tuple-unpacking`` when a tuple is assigned to a function call and the structure of the function's return value is ambiguous. Closes #10721 Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 1496340)
Pierre-Sassoulas
added a commit
that referenced
this pull request
Nov 9, 2025
β¦ple-unpacking``. (#10726) Fix a false positive for ``unbalanced-tuple-unpacking``. (#10724) * Fix a false positive for ``unbalanced-tuple-unpacking`` when a tuple is assigned to a function call and the structure of the function's return value is ambiguous. Closes #10721 (cherry picked from commit 1496340) Co-authored-by: Mark Byrne <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false positive for
unbalanced-tuple-unpackingwhen a tuple is assigned to a function call and the structure of the function's return value is ambiguous.Closes #10721