Skip to content

Implement icdf for Bernoulli#8343

Merged
ricardoV94 merged 1 commit into
pymc-devs:mainfrom
jacobpstein:add-icdf-bernoulli
Jul 7, 2026
Merged

Implement icdf for Bernoulli#8343
ricardoV94 merged 1 commit into
pymc-devs:mainfrom
jacobpstein:add-icdf-bernoulli

Conversation

@jacobpstein

Copy link
Copy Markdown
Contributor

Adds a closed-form icdf for Bernoulli. Split out from #8339 since it needs no numerical search and is trivial to review on its own.

@welcome

welcome Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thank You Banner]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@read-the-docs-community

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.76%. Comparing base (9d24260) to head (d41871f).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8343       +/-   ##
===========================================
+ Coverage   79.80%   91.76%   +11.96%     
===========================================
  Files         125      128        +3     
  Lines       20526    20657      +131     
===========================================
+ Hits        16380    18956     +2576     
+ Misses       4146     1701     -2445     
Files with missing lines Coverage Δ
pymc/distributions/discrete.py 99.43% <100.00%> (+37.65%) ⬆️

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94
ricardoV94 merged commit 56384e5 into pymc-devs:main Jul 7, 2026
42 checks passed
@welcome

welcome Bot commented Jul 7, 2026

Copy link
Copy Markdown

Congratulations Banner]
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants