Fix wrong parameter name in function docstring. Fix set_values does not accept tuple.#2858
Merged
janiversen merged 3 commits intopymodbus-dev:devfrom Feb 6, 2026
Merged
Fix wrong parameter name in function docstring. Fix set_values does not accept tuple.#2858janiversen merged 3 commits intopymodbus-dev:devfrom
janiversen merged 3 commits intopymodbus-dev:devfrom
Conversation
janiversen
requested changes
Feb 2, 2026
pymodbus/datastore/sparse.py
Outdated
|
|
||
| :param address: The starting address | ||
| :param values: The new values to be set | ||
| f"""Set the requested values of the datastore. |
Collaborator
There was a problem hiding this comment.
This seems wrong, normally method documentation is not an f-string.
Remark, that is the reason why CI complains (did not check if it complains about other things).
Collaborator
|
Please be aware that a new release is due in the coming 1-2 weeks. Please correct the CI issue. |
…le when register values are given as dictionary, but not when given directly with starting address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
these are two fixes, should be self-explanatory and keeping changes minimal.
(And a fully typed pymodbus would be on my wishlist..)