Move darwin special config dir to pip wrapper - #7791
Merged
Conversation
xavfernandez
force-pushed
the
move_more_appdirs_patch
branch
2 times, most recently
from
February 28, 2020 10:34
fe88737 to
484170e
Compare
xavfernandez
added
the
skip news
xavfernandez
marked this pull request as ready for review
March 3, 2020 09:12
Member
|
I think we should keep things which we would ideally upstream in the patch file, instead of bringing them into pip like this. |
Member
Author
Our vendoring policy clearly states So this PR is just trying to reduce the heavy patching of appdirs we perform to conform to our own policy. This should not prevent us from actually upstreaming this patch. |
Member
Author
I've opened ActiveState/appdirs#137 |
xavfernandez
force-pushed
the
move_more_appdirs_patch
branch
from
March 10, 2020 12:42
484170e to
633e17f
Compare
uranusjr
approved these changes
Mar 12, 2020
Member
Author
|
Thanks for the review |
lock
Bot
added
the
auto-locked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #7787 to be merged.
Related to #7705