fix(distributions.conjugate): support total_count_max in DirichletMultinomial distribution#2016
Conversation
|
Looks like we're encountering the same CI failure as in #2015 #2015 (comment) |
58e2510 to
6b8780f
Compare
|
Could you mark this test as xfail in CI instead? like in https://github.com/pyro-ppl/numpyro/blob/master/test/test_examples.py#L52-L59 |
6b8780f to
01d1fc2
Compare
Absolutely. Done. |
fehiepsi
left a comment
There was a problem hiding this comment.
Thanks @brendancooley! Could you remove committed png and graph files?
yeesh yes of course. added |
|
|
||
| # data files | ||
| *.png |
There was a problem hiding this comment.
We might want to add png as part of the docs right https://github.com/pyro-ppl/numpyro/tree/master/docs/source/_static/img/examples ?
There was a problem hiding this comment.
Happy to put up a PR to revert the change...or maybe try and manage artifact generation during the tests a bit better so that these files don't end up polluting the root directory. Did I miss something in the contributor notes on existing ways to manage this?
Follow on to #1557 for the
DirichletMultinomialcase.Prior to this change, users may encounter the error
ValueError("Please specify total_count_max in Multinomial distribution.")(seemultinomialindistributions.util) when using the distribution inside of traced environments and lack recourse to address the problem.