Harden opt-in upload privacy and reliability#1343
Open
KushGandhi3 wants to merge 8 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 26371929739Coverage increased (+0.02%) to 90.866%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
Author
|
Hi Professor @david-yz-liu, this PR is ready for review. I don't seem to have the option to request reviewers on this PR, and this has happened on my previous PR as well. Would it be possible to give me permission to request reviews on future PRs, or let me know the preferred process? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request hardens PythonTA's opt-in upload path for privacy, reliability, and test coverage.
Previously, the anonymous upload ID was derived from
uuid.uuid1(), which can include MAC-address-derived information before hashing. This change replaces that behavior with a random local UUID, stores it on the user's machine, and sends only a SHA-512 hash of that local ID to the upload server. The uploaded ID format remains a 128-character hexadecimal hash, andget_hashed_id()is preserved as a backwards-compatible alias.This PR also improves upload reliability by:
ExitStackerrors_to_dictDocumentation and the changelog were updated to describe the new anonymous ID behavior, including the fact that existing opt-in users will receive a new anonymous ID after upgrading.
Screenshots of your changes (if applicable)
Not applicable; this PR does not change the UI.
Type of Change
Checklist
Before opening your pull request:
After opening your pull request:
Questions and Comments