Open
Conversation
BeyondEvil
reviewed
Nov 15, 2023
Contributor
BeyondEvil
left a comment
BeyondEvil
left a comment
There was a problem hiding this comment.
We should probably add mypy for type checking.
Member
|
Hey @jeffwright13 thank you for your work on this. Are you still interested by this ? I merged the latest changes from main where mypy and other typing hints were added but there's too much mypy errors for my current understanding of the code to handle them myself (you can check the pre-commit job in the CI). |
Pierre-Sassoulas
added
code quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 'legacy-style' type annotations to file
basereport.py. This is for backwards compatibility with older version of Python <= 3.8).