Modify the config files to be able to run the examples - #10
Conversation
gubaidulinvadim
left a comment
gubaidulinvadim
left a comment
There was a problem hiding this comment.
OK, I see this is a bit more than defining arrays and tuning tools. There were BPMS and Corrector magnets missing in the test lattice config files. Looks good! I have a question on .description files. I do not understand what is this.
There was a problem hiding this comment.
What are the .description files?
There was a problem hiding this comment.
From the README.md
Optional descriptions can be added without changing the registry. Place a
file named <filename>.description next to any lattice or
configuration file. Its text is displayed when printing the registry:
fodo_1gev_6d.json.description
To list the available files and their description, print a registry:
print(configurations)
There was a problem hiding this comment.
They are to provide a description to explain what the different files are when you use the functionality of the package to list available configurations to choose from. If there is no .description file there will just be no description printed so they are not mandatory.
There was a problem hiding this comment.
Like in this tutorial: https://python-accelerator-middle-layer.github.io/documentation/tutorials/01_create_accelerator.html#prerequisites
The descriptions of the file in that output come from the .description files.
There was a problem hiding this comment.
I do not understand the need for it but as long as this is optional I do not care.
There was a problem hiding this comment.
It's just to provide the users with some quick info about which file to load depending on what they want to test. For example, which config file to use if they want to try the tango-pyaml vs the pyaml-cs-oa tango bindings.
|
Thank you so much @GamelinAl :) I will try making the examples into tutorials again this evening. If there is some new problem I think I should be able to figure out how to fix it myself with this start. |
3 participants
This MR try to solve #7
I did some configuration changes that should be ok pour pyaml in design mode.
I did some other checks with the live mode and dt4acc and it seems to work also.
Probably this will need further changes in the future but for now this should work.