Skip to content

compressible_fv4 does not need to reimplement evolve #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zingale merged 3 commits into from
Jan 24, 2025
Merged

compressible_fv4 does not need to reimplement evolve #332

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a89196
compressible_fv4 does not need to reimplement evolve
zingale Jan 24, 2025
3021e6f
flake8
zingale Jan 24, 2025
bb112b9
fix
zingale Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 1 addition & 35 deletions pyro/compressible_fv4/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pyro.compressible_fv4.fluxes as flx
from pyro import compressible_rk
from pyro.compressible import get_external_sources, get_sponge_factor
from pyro.mesh import fv, integration
from pyro.mesh import fv


class Simulation(compressible_rk.Simulation):
Expand Down Expand Up @@ -66,37 +66,3 @@ def preevolve(self):
# we just initialized cell-centers, but we need to store averages
for var in self.cc_data.names:
self.cc_data.from_centers(var)

def evolve(self):

"""
Evolve the equations of compressible hydrodynamics through a
timestep dt.
"""

tm_evolve = self.tc.timer("evolve")
tm_evolve.begin()

myd = self.cc_data

method = self.rp.get_param("compressible.temporal_method")

rk = integration.RKIntegrator(myd.t, self.dt, method=method)
rk.set_start(myd)

for s in range(rk.nstages()):
ytmp = rk.get_stage_start(s)
ytmp.fill_BC_all()
k = self.substep(ytmp)
rk.store_increment(s, k)

rk.compute_final_update()

if self.particles is not None:
self.particles.update_particles(self.dt)

# increment the time
myd.t += self.dt
self.n += 1

tm_evolve.end()
Loading