Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #710 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2149 2173 +24
Branches 97 100 +3
=========================================
+ Hits 2149 2173 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
StanFromIreland
self-requested a review
September 24, 2026 20:15
StanFromIreland
approved these changes
Sep 25, 2026
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
The current change looks correct to me.
Two points, however, that I'd like to highlight on the general design:
- Removing the label isn't recorded. I fear this may come up in practice, e.g. possibly in the case of docs issues (which are sometimes labelled as
type-feature), but it's avoidable by also removing it from the issue, so it's not a major issue. - It doesn't sync on updates to the issue. So if the
type-featurelabel is added to an issue after the PR is opened, it won't automatically be propagated, unless the PR itself is also updated. This means it could be missed before a merge.
Neither of these are too troublesome or likely to come up in practice, so I think we can try the current (simpler) implementation, and revisit if the issues pop up in practice. In any case, please post an announcement after deploying as it's likely to cause some confusion, especially considering the "two weeks" since this was originally discussed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase two of Workflow change coming: mandatory reviews on new features:
Two weeks is a long time in open source :)