gh-131798: optimize CALL_KW_PY in the JIT#148466
Open
kumaraditya303 wants to merge 4 commits intopython:mainfrom
Open
gh-131798: optimize CALL_KW_PY in the JIT#148466kumaraditya303 wants to merge 4 commits intopython:mainfrom
kumaraditya303 wants to merge 4 commits intopython:mainfrom
Conversation
kumaraditya303
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
Lib/test/test_capi/test_opt.py
Outdated
|
|
||
| def test_call_kw(self): | ||
| def func(a): | ||
| return 42 * a |
Member
There was a problem hiding this comment.
We should be checking that we optimize through the trace. So the best way is to put a global (e.g. range) here and check if it gets promoted in the tests below. See for example test_init_resolves_callable which does self.assertNotIn("_LOAD_GLOBAL_BUILTINS", uops). Same for the other test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.