gh-152586: Make tempfile.TemporaryFileWrapper public#152646
Conversation
Documentation build overview
28 files changed ·
|
| self.assertIn("TemporaryFileWrapper", tempfile.__all__) | ||
|
|
||
| def test_is_return_type_of_named_temporary_file(self): | ||
| with tempfile.NamedTemporaryFile() as f: |
There was a problem hiding this comment.
I propose to move this check to any existing test above.
| for line in self.file: | ||
| yield line | ||
|
|
||
| _TemporaryFileWrapper = TemporaryFileWrapper |
There was a problem hiding this comment.
Please, add a comment: why it is there.
Question: does it make sence to deprecate the older alias at the same time?
There was a problem hiding this comment.
Please, add a comment: why it is there.
sure 👍
Question: does it make sence to deprecate the older alias at the same time?
I think we can deprecate in follow up, but if you prefer we should add in this PR, only-- i'm happy to go with
Thanks for the review!
There was a problem hiding this comment.
I would deprecate it right away :)
Co-authored-by: sobolevn <mail@sobolevn.me>
ByteFlowing1337
left a comment
ByteFlowing1337
left a comment
There was a problem hiding this comment.
I think these changes need a news entry. Could you please add one?
| raw = getattr(raw, 'raw', raw) | ||
| raw.name = name | ||
| return _TemporaryFileWrapper(file, name, delete, delete_on_close) | ||
| return TemporaryFileWrapper(file, name, delete, delete_on_close) |
There was a problem hiding this comment.
test_unexpected_error is failing because you did not change mock.patch('tempfile._TemporaryFileWrapper') to mock.patch('tempfile.TemporaryFileWrapper') in that function.
There was a problem hiding this comment.
thanks for pointing out
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Please, also add a new deprecation entry to Doc/whatsnew/3.16.rst and add tempfile._TemporaryFileWrapper to be removed to Doc/deprecations/pending-removal-in-3.21.rst
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: sobolevn <mail@sobolevn.me>
…uEae6.rst Co-authored-by: sobolevn <mail@sobolevn.me>
|
Please, resolve conflicts :) |
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: sobolevn <mail@sobolevn.me>
|
Let's ask @savannahostrowski as the release manager of 3.16 if this change is ok :) |
Co-authored-by: sobolevn <mail@sobolevn.me>
…uEae6.rst Co-authored-by: sobolevn <mail@sobolevn.me>
3 participants
Fixes #152586