gh-152769: Enable perf trampoline on Alpine#152774
Open
weixlu wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@vstinner Hi, this is the PR fixing perf trampolines on musl. Could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal of change
As mentioned in #152769,
perfcan‘t collect Python function-level hotspot info on Alpine Linux because perf trampoline support is not enabled there.The trampoline is a CPU-architecture-specific feature and has little to do with OS or libc. Therefore, we can simply modify
configureto reuse the same trampoline implementation as glibc.Test results
I ran the tests on the following three platforms:
The three profiling-related tests now pass on all of these platforms:
Before this PR, these tests were skipped.
I also manually collected profiling data with
perfand confirmed that Python-level functions appear in the profiling output.How to reproduce
When running Alpine in a container, note that the container needs to be started with the additional
--privilegedoption.Apart from build dependencies, install
perfandsamply.samplyneeds to be built with Rust:./python -m test test_perf_profiler test_perfmaps test_samply_profiler