Skip to content

Skip do_not_record proposals when uploading videos to YouTube - #4809

Merged
marcoacierno merged 1 commit into
mainfrom
skip-do-not-record-video-upload
Aug 17, 2026
Merged

Skip do_not_record proposals when uploading videos to YouTube#4809
marcoacierno merged 1 commit into
mainfrom
skip-do-not-record-video-upload

Conversation

@marcoacierno

Copy link
Copy Markdown
Member

What

The Upload videos to YouTube admin action queued every schedule item that had a video file and no YouTube ID, ignoring Submission.do_not_record. On PyCon Italia 2026 this uploaded 4 talks whose speakers had opted out of recording (schedule items 1083, 1160, 1161, 1176), and drafted the "video recording uploaded" email to those speakers.

This adds .exclude(submission__do_not_record=True) to the action's queryset. Items without a submission (custom items) are unaffected, since the exclude on the join doesn't match NULL.

Test: test_upload_videos_to_youtube_skips_do_not_record_submissions.

Notes

  • Only the admin action is filtered. upload_schedule_item_video / process_schedule_items_videos_to_upload still process any ScheduleItemSentForVideoUpload rows that already exist, so previously queued do-not-record items are not stopped by this change.
  • Unrelated, found while writing the test: ScheduleItemFactory.type is still FuzzyChoice(["submission", "custom"]) even though the submission type was removed. When it rolls custom the factory drops the submission passed in, which makes tests randomly flaky.

ToDo

  • Decide whether the celery task should also guard on do_not_record
  • Clean up the 4 already-uploaded videos + their draft emails on production

The "Upload videos to YouTube" admin action queued every schedule item
with a video file, including talks whose speakers asked not to be
recorded.
@claude

claude Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Reviewed. The fix (adding .exclude(submission__do_not_record=True)) is correct: since submission is a single-valued forward FK, Django's exclude() on it won't drop rows where submission is NULL, so custom schedule items without a submission are still included — matches the test and the PR description.

No issues found.

@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Aug 17, 2026 2:54pm

@marcoacierno
marcoacierno merged commit b2a9499 into main Aug 17, 2026
9 checks passed
@marcoacierno
marcoacierno deleted the skip-do-not-record-video-upload branch August 17, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant