Conversation
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120862981. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
meta-codesync
Bot
changed the title
q10
force-pushed
the
export-D120862981
branch
from
September 21, 2026 02:05
35b058c to
1491019
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: pytorch#6333 Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
force-pushed
the
export-D120862981
branch
from
September 21, 2026 02:09
1491019 to
41c1f5f
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: pytorch#6333 Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
force-pushed
the
export-D120862981
branch
from
September 21, 2026 07:49
41c1f5f to
12bd723
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Pull Request resolved: pytorch#6333 Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Pull Request resolved: pytorch#6333 Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
q10
force-pushed
the
export-D120862981
branch
from
September 22, 2026 20:27
12bd723 to
ac9bd74
Compare
Summary: Mark contract-required parameters unused in TBE vector and stochastic-rounding helpers. The affected overloads are unsupported-operation stubs or CUDA/ROCm-specific helpers whose uniform signatures intentionally retain parameters that some configurations do not read. Use unnamed parameters (`/* param */`) where values are never read, and retain `[[maybe_unused]]` for the shuffle mask that is used by CUDA but not ROCm. Make unsupported `Vec4AccT` assertions carry an actionable message without changing supported behavior. Differential Revision: D121257626
Summary: Mark parameters unused where TBE portability helpers consume them only on selected GPU platforms or architectures. The affected embedding, ROCm split-embedding, and warp primitive helpers keep uniform interfaces across CUDA and ROCm. Use unnamed parameters (`/* param */`) for unsupported stubs and values never read, and retain `[[maybe_unused]]` for arguments used only by a platform- or architecture-specific branch. Differential Revision: D121257627
Summary: Mark contract-required parameters unused in generated TBE update helpers, cache insertion, and input transposition. The generated rowwise-Adagrad table-update helper receives optimizer placement and offset arrays through the uniform `split_ref_kernel_args` contract but consumes separately derived scalar values. Silence those helper-local diagnostics in the owning template, while retaining the arrays for the outer GPU kernel that genuinely reads them. Also annotate configuration-specific cache and transpose parameters. Differential Revision: D121257628
Summary: Mark contract-required parameters unused in GenAI attention and KV-cache implementations. The affected parameters belong to architecture-gated attention kernels, Meta implementations, and an intentionally unimplemented paged-cache kernel. Preserve their public and kernel signatures while making the configuration-specific unusedness explicit. Differential Revision: D121257629
Summary: Mark contract-required parameters unused across GenAI quantization backends and CK extensions. The affected Meta functions, version-gated CUDA fallbacks, HIP kernels, and CK wrappers retain stable public signatures across implementations. Add `[[maybe_unused]]` where a particular backend or toolchain configuration intentionally does not consume an argument. Differential Revision: D121257631
Summary: Mark API-compatibility parameters unused in GenAI communication and MoE operators. CAR retains `world_size` and `comm_idx` across backend-compatible entry points even where the current implementation does not consume them. The index-shuffling Meta implementation similarly preserves optional runtime arguments while deriving only output shapes. Differential Revision: D121257633
Summary: X-link: https://github.com/facebookresearch/FBGEMM/pull/3205 Pull Request resolved: pytorch#6339 Remove the mirrored OSS `-Wno-error=unused-parameter` escapes after the configuration-specific source cleanup in prerequisite diffs D121257626, D121257627, D121257628, D121257629, D121257631, and D121257633. This final diff changes only the two `CppLibrary.cmake` copies, making unused parameters fatal across CXX, nvcc host, and hipcc while keeping the enforcement change independently reviewable. Differential Revision: D120859871
Summary: Pull Request resolved: pytorch#6338 Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
Summary: Pull Request resolved: pytorch#6337 Remove the CMake, Buck, and Apple-specific shadow-warning demotions from both FBGEMM mirrors. The preceding constructor cleanup eliminates the measured OSS shadow diagnostics, so all supported build paths now enforce `-Wshadow` instead of merely reporting or suppressing it. Differential Revision: D120862977
Summary: Pull Request resolved: pytorch#6336 Remove the OSS CMake demotion for `-Wzero-as-null-pointer-constant`. Third-party headers are now treated as system includes, and the full OSS CPU library builds cleanly with the warning fatal, matching internal enforcement. Differential Revision: D120862978
Summary: Pull Request resolved: pytorch#6335 Remove the OSS CMake demotion for `-Wattributes`. Full GCC and Clang CPU library builds complete cleanly with the warning fatal. Differential Revision: D120862979
Summary: Pull Request resolved: pytorch#6334 Make `-Wunused-but-set-parameter` and `-Wunused-but-set-variable` fatal in the OSS GCC and Clang warning profiles, including the mirrored xplat Buck defaults. Both compiler builds are clean, so the version-gated suppression bucket is no longer needed. Differential Revision: D120862980
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Reviewed By: r-barnes Differential Revision: D120862981
q10
force-pushed
the
export-D120862981
branch
from
September 22, 2026 21:02
ac9bd74 to
2e37630
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Reviewed By: r-barnes Differential Revision: D120862981
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Pull Request resolved: pytorch#6333 Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Differential Revision: D120862981
Summary: Pull Request resolved: pytorch#6333 Remove the OSS Clang/HIP and xplat Apple demotions for `-Wglobal-constructors`. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal. Reviewed By: r-barnes Differential Revision: D120862981
q10
force-pushed
the
export-D120862981
branch
from
September 22, 2026 21:05
2e37630 to
d99e00a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove the OSS Clang/HIP and xplat Apple demotions for
-Wglobal-constructors. The complete OSS Clang CPU library and the internal fbcode FBGEMM package build cleanly with the warning fatal.Reviewed By: r-barnes
Differential Revision: D120862981