Conversation
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120862976. |
meta-codesync
Bot
changed the title
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
force-pushed
the
export-D120862976
branch
from
September 21, 2026 02:05
afe8e0c to
ce2230f
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: pytorch#6338 Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
force-pushed
the
export-D120862976
branch
from
September 21, 2026 02:07
ce2230f to
39106d2
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
force-pushed
the
export-D120862976
branch
from
September 21, 2026 02:11
39106d2 to
562ae7e
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: pytorch#6338 Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
force-pushed
the
export-D120862976
branch
from
September 21, 2026 02:17
562ae7e to
a18ab66
Compare
Summary: Remove names from parameters intentionally unused by default KV interfaces, parameter-server stubs, SSD cache hooks, and checkpoint helpers. This preserves the override contracts while making the combined SSD table target clean under `-Werror=unused-parameter`. Differential Revision: D120941426
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: pytorch#6338 Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
force-pushed
the
export-D120862976
branch
from
September 21, 2026 07:48
a18ab66 to
5307001
Compare
Summary: Mark contract-required parameters unused in TBE vector and stochastic-rounding helpers. The affected overloads are unsupported-operation stubs or CUDA/ROCm-specific helpers whose uniform signatures intentionally retain parameters that some configurations do not read. Add `[[maybe_unused]]` without changing the supported operations, and make unsupported `Vec4AccT` assertions carry an actionable message. Differential Revision: D121257626
Summary: Mark parameters unused where TBE portability helpers consume them only on selected GPU platforms or architectures. The affected embedding, ROCm split-embedding, and warp primitive helpers keep uniform interfaces across CUDA and ROCm. Add `[[maybe_unused]]` to the arguments intentionally omitted by a platform or architecture-specific branch. Differential Revision: D121257627
Summary: Mark contract-required parameters unused in generated TBE update helpers, cache insertion, and input transposition. The generated rowwise-Adagrad table-update helper receives optimizer placement and offset arrays through the uniform `split_ref_kernel_args` contract but consumes separately derived scalar values. Silence those helper-local diagnostics in the owning template, while retaining the arrays for the outer GPU kernel that genuinely reads them. Also annotate configuration-specific cache and transpose parameters. Differential Revision: D121257628
Summary: Mark contract-required parameters unused in GenAI attention and KV-cache implementations. The affected parameters belong to architecture-gated attention kernels, Meta implementations, and an intentionally unimplemented paged-cache kernel. Preserve their public and kernel signatures while making the configuration-specific unusedness explicit. Differential Revision: D121257629
Summary: Mark contract-required parameters unused across GenAI quantization backends and CK extensions. The affected Meta functions, version-gated CUDA fallbacks, HIP kernels, and CK wrappers retain stable public signatures across implementations. Add `[[maybe_unused]]` where a particular backend or toolchain configuration intentionally does not consume an argument. Differential Revision: D121257631
Summary: Mark API-compatibility parameters unused in GenAI communication and MoE operators. CAR retains `world_size` and `comm_idx` across backend-compatible entry points even where the current implementation does not consume them. The index-shuffling Meta implementation similarly preserves optional runtime arguments while deriving only output shapes. Differential Revision: D121257633
Summary: X-link: https://github.com/facebookresearch/FBGEMM/pull/3205 Pull Request resolved: pytorch#6339 Remove the OSS `-Wno-error=unused-parameter` escape and annotate the remaining configuration-specific unused parameters exposed by CPU, CUDA, ROCm, and GenAI builds. This preserves the hard warning gate across CXX, nvcc host, and hipcc while keeping platform-specific stubs and conditional branches warning-clean. Differential Revision: D120859871
q10
force-pushed
the
export-D120862976
branch
from
September 22, 2026 20:25
5307001 to
c2e1258
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Pull Request resolved: pytorch#6338 Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
Summary: Pull Request resolved: pytorch#6338 Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
q10
force-pushed
the
export-D120862976
branch
from
September 22, 2026 20:28
c2e1258 to
892fb1e
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Reviewed By: r-barnes Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Reviewed By: r-barnes Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Reviewed By: r-barnes Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Reviewed By: r-barnes Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Reviewed By: r-barnes Differential Revision: D120862976
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Sep 22, 2026
Summary: Pull Request resolved: pytorch#6338 Rename three constructor parameters that shadow their destination members: the convolution `transposed` flag and the embedding-statistics batch and bag sizes. This removes the complete `-Wshadow` output observed in the local OSS CPU build without changing initialized values or public argument ordering. Differential Revision: D120862976
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Rename three constructor parameters that shadow their destination members: the convolution
transposedflag and the embedding-statistics batch and bag sizes. This removes the complete-Wshadowoutput observed in the local OSS CPU build without changing initialized values or public argument ordering.Differential Revision: D120862976