Conversation
Summary: NOTE: No linked task. Please associate a task with this diff. Add grid-stride loops to the linearization and group-length kernels so large launches remain correct when grid.x is capped. On ROCm, apply the occupancy/safety cap on every launch; CUDA retains overflow-only behavior. Preserve empty groups and validate that sample counts fit 32-bit accessors, batch size defines at least one table, and HIP table launches stay within the inclusive thread limit. Add a ROCm regression sized one block beyond the cap so both kernels execute a second grid-stride iteration. Reviewed By: jianyuh Differential Revision: D116334991
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116334991. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
NOTE: No linked task. Please associate a task with this diff.
Add grid-stride loops to the linearization and group-length kernels so large launches remain correct when grid.x is capped. On ROCm, apply the occupancy/safety cap on every launch; CUDA retains overflow-only behavior.
Preserve empty groups and validate that sample counts fit 32-bit accessors, batch size defines at least one table, and HIP table launches stay within the inclusive thread limit. Add a ROCm regression sized one block beyond the cap so both kernels execute a second grid-stride iteration.
Reviewed By: jianyuh
Differential Revision: D116334991