Conversation
Summary: Mark contract-required parameters unused in TBE vector and stochastic-rounding helpers. The affected overloads are unsupported-operation stubs or CUDA/ROCm-specific helpers whose uniform signatures intentionally retain parameters that some configurations do not read. Use unnamed parameters (`/* param */`) where values are never read, and retain `[[maybe_unused]]` for the shuffle mask that is used by CUDA but not ROCm. Make unsupported `Vec4AccT` assertions carry an actionable message without changing supported behavior. Differential Revision: D121257626
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121257626. |
Contributor
|
This pull request has been merged in 65d0de9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Mark contract-required parameters unused in TBE vector and stochastic-rounding helpers.
The affected overloads are unsupported-operation stubs or CUDA/ROCm-specific helpers whose uniform signatures intentionally retain parameters that some configurations do not read. Use unnamed parameters (
/* param */) where values are never read, and retain[[maybe_unused]]for the shuffle mask that is used by CUDA but not ROCm. Make unsupportedVec4AccTassertions carry an actionable message without changing supported behavior.Differential Revision: D121257626