4/x: mx cleanup: use kernel_preference instead of gemm_kernel_choice #3385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3385
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Nov 24, 2025
Summary: Moves MX workflows to use torchao-wide `kernel_preference`. * MXGemmKernelPreference.CUBLAS -> KernelPreference.AUTO * MXGemmKernelPreference.CUTLASS -> KernelPreference.AUTO * MXGemmKernelPreference.EMULATED -> KernelPreference.EMULATED Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 726b651 ghstack-comment-id: 3572455799 Pull-Request: #3385
meta-cla
bot
added
the
CLA Signed
This was referenced Nov 24, 2025
vkuzo
added
topic: improvement
This was referenced Nov 24, 2025
jerryzh168
reviewed
Nov 24, 2025
| m = nn.Linear(32, 128, bias=bias, dtype=torch.bfloat16, device="cuda") | ||
| m_mx = copy.deepcopy(m) | ||
|
|
||
| if emulate: |
Contributor
There was a problem hiding this comment.
nit: can just use KernelPreference in parametrize as well I think
jerryzh168
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves MX workflows to use torchao-wide
kernel_preference.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: