benchmarks: allow external kernel mappings for Helion run.py #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running internal benchmarks using TritonBench with Helion as a runner, I found it inconvenient to repeatedly edit benchmarks/run.py to add or tweak KERNEL_MAPPINGS / KERNEL_METRIC_MAPPINGS for new kernels I wanted to test.
This change keeps the current behavior unchanged by default, but adds an optional way to provide kernel mappings via a config file so users don’t need to modify run.py every time.
This PR adds a new optional CLI arg
--kernel-configwhich points to a yaml or a json file that describe kernel_mappings, kernel_metric_mappings as per current run.py.