Adds use of GCPDefinition instead of SwathDefinition to Modis L1b reader #2283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce the use of
GCPDefinition(SwathDefinitionwith ground control points pytroll/pyresample#476) for the Modis L1b reader.This should be used as a base for discussion of how/where
SwathDefinitions/GCPDefinitionsshould be created reader/FileYAMLReader. Currently ifget_area_defis not implemented in the reader aSwathDefinitionis created in theFileYAMLReaderas a "fallback" in a kind of way.Possible Questions:
get_area_deftoget_areain the reader to make it clearer that this should be used for creation ofAreaDefinitionsas well asSwathDefinitions(with control points).FileYAMLReaderand readers how to createSwathDefinitionswith ground control points and interpolation?...