-
Notifications
You must be signed in to change notification settings - Fork 320
Landsat MSS reader _get_matched_dataset_info bug fix
#3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Landsat MSS reader _get_matched_dataset_info bug fix
#3300
Conversation
|
Thanks! ...but how has this ever worked? |
|
Tests were not failing, because we test only B4 band, and for B4 it worked correctly, hahah |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3300 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 463 463
Lines 58870 58880 +10
=======================================
+ Hits 56711 56722 +11
+ Misses 2159 2158 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 19578152038Details
💛 - Coveralls |
|
|
I already do not have an exact error message, but it crased on this line from coordinates = ds_info.get("coordinates")with error like We can add additional band tests, like testing also B5 for Landsat 1 and B3 for Landsat 4 |
|
I added testing "B5" band for Landsat 1 and "B3" for Landsat 4, by adding the corresponding fixtures for these bands and trying to open them in |
Function
_get_matched_dataset_infoshould return only dataset info, not a tuple of (True, info)AUTHORS.mdif not there already