Fix test to not save two geotiffs with the same name #3318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnuu
approved these changes
Dec 18, 2025
Member
|
To be more specific, we don't want to support saving two datasets to one image file. Saving to NetCDF4 is a valid usecase. |
Member
|
Zenodo is again acting up, I restarted the tests. |
Member
|
Another restart, same reason. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
==========================================
- Coverage 96.34% 96.31% -0.03%
==========================================
Files 463 463
Lines 58916 58916
==========================================
- Hits 56760 56745 -15
- Misses 2156 2171 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows started failing in CI because this test was trying to save 2 DataArrays to the same output filename. That is not a use case we want to support, but I think was done accidentally as the test class evolved. This PR updates the test to be explicit about what dataset is being saved and Windows CI passes now.
AUTHORS.mdif not there already