-
Notifications
You must be signed in to change notification settings - Fork 57
Fixing C2v, adding stereographic plots for every point group, and making SYmmetry match ITOC standards #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
argerlt
wants to merge
54
commits into
pyxem:develop
Choose a base branch
from
argerlt:UpdatingSymmetryWithExamples
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 17 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
a31bca1
Correct C2v to match ITOC
argerlt ca5a391
matching symmetry lists and names to ITOC
argerlt 37a9db7
update _get_laue_group_name to be proceedural instead of a name-based…
argerlt 445435f
expand symmetry marker and add example
argerlt 8e3e490
formatting
argerlt c9d17ab
make tables sphinx-compatable
argerlt c01f09b
formatting
argerlt ecf5a5a
add suggestions from #563 review
argerlt 228a7dc
Merge branch 'develop' into UpdatingSymmetryWithExamples
argerlt a9af706
moving plot_symmetry_operations algo to Symmetry function
argerlt b46e977
formatting
argerlt d9bbfd5
create PointGroups class, improve Symmetry.plot, and fix example
argerlt fed56bc
formatting
argerlt da8269d
finishing symmetry.plot and adding to PointGroups
argerlt 46e8663
typos
argerlt 19b6e47
formatting
argerlt 276d456
more formatting
argerlt 31b13be
Update RTD objects.inv link
hakonanes 55be041
Disallow numpydoc v1.9.0 (#570)
hakonanes 556a8ad
Specify custom pytest markers in pyproject.toml, simplify naming (#570)
hakonanes c87ece2
Fix rst formatting typo (#570)
hakonanes ea29fb2
Fix docstring of new expand asymmetric unit function (#570)
hakonanes 10db466
Fix docstring of new to/from SciPy rotation functions (#570)
hakonanes 7632cef
Update type hints in rotation class (#570)
hakonanes 2fe05da
Remove test fixture that unnecessarily complicated use of files (#570)
hakonanes d9074cb
Remove use of typing.Self, which is not available until Python 3.11 (…
hakonanes 9a81c45
Error codes description in CTF file
ondrolexa ecb3db4
format fix
ondrolexa 8d7c8f6
Add @ondrolexa to contributors, sort according to additions list on d…
hakonanes 102f5f5
Update type hints and modify code slightly in CTF reader
hakonanes 46c6cac
Make CTF reader less error prone, improve comments
hakonanes fb3004c
Merge pull request #574 from ondrolexa/ctf-reader-codes
hakonanes 89a1bf6
Merge pull request #571 from hakonanes/570-fix-doc-build-numpydoc
hakonanes 085be4a
Correct C2v to match ITOC
argerlt 5c6a8f7
matching symmetry lists and names to ITOC
argerlt daf7b65
update _get_laue_group_name to be proceedural instead of a name-based…
argerlt 5e1f8cd
expand symmetry marker and add example
argerlt 9fc91d6
formatting
argerlt 54cd0a1
make tables sphinx-compatable
argerlt 70adbc7
formatting
argerlt 18d9005
add suggestions from #563 review
argerlt ec32242
moving plot_symmetry_operations algo to Symmetry function
argerlt 9478f33
formatting
argerlt e71059e
create PointGroups class, improve Symmetry.plot, and fix example
argerlt c35bc06
formatting
argerlt f472f11
finishing symmetry.plot and adding to PointGroups
argerlt 1c381b3
typos
argerlt c541b31
formatting
argerlt 8e38b67
more formatting
argerlt 1460020
Documentation improvements
argerlt 154405f
Merge branch 'UpdatingSymmetryWithExamples' of https://github.com/arg…
argerlt ae62fcf
Addressing feedback on #563
argerlt 3e9aa80
fix broken reference to old class feature
argerlt 396972c
fix D3h name and improve explination on plot_symmetry_operations.py
argerlt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.