Skip to content

Conversation

@Harnas
Copy link

@Harnas Harnas commented Dec 16, 2025

Wrong name causes HTTP redirection, what may be wrongly handled by proxies.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Wrong name causes HTTP redirection, what may be wrongly handled by proxies.
@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

📝 Walkthrough

Walkthrough

Updated the HuggingFace model source identifier for the BAAI/bge-base-en-v1.5 ONNX embedding model variant in fastembed/text/onnx_embedding.py. The identifier was changed from qdrant/bge-base-en-v1.5-onnx-q to Qdrant/bge-base-en-v1.5-onnx-Q, reflecting casing adjustments and path updates. No changes were made to model metadata, URLs, or file paths beyond this identifier update.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single configuration string update with no logic modifications
  • No structural or semantic changes affecting functionality
  • Verify that the updated model identifier correctly resolves to the intended HuggingFace repository and that the casing/path change is intentional and matches the actual model source

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: correcting the model name from 'qdrant/bge-base-en-v1.5-onnx-q' to 'Qdrant/bge-base-en-v1.5-onnx-Q'.
Description check ✅ Passed The description is related to the changeset, explaining that the wrong model name causes HTTP redirections that may be mishandled by proxies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 685fd9b and dd8bc0e.

📒 Files selected for processing (1)
  • fastembed/text/onnx_embedding.py (1 hunks)
🔇 Additional comments (1)
fastembed/text/onnx_embedding.py (1)

37-37: The casing correction to Qdrant/bge-base-en-v1.5-onnx-Q is valid.

The corrected HuggingFace path matches the actual model repository. Uppercase "Qdrant" and "Q" are the correct casing for this model identifier on HuggingFace, which resolves the HTTP redirect issue mentioned in the PR.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant