refactor: Store num-workers in the offset key #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anush008 <anushshetty90@gmail.com>
Anush008
force-pushed
the
store-num-workers-in-offset-id
branch
from
2c7dd7f to
f19532a
Compare
superseb
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parallel migration splits the work into ranges, and the number of ranges depends on
num-workers.Before, offset keys did not include the worker count. If you changed
num-workersbetween runs, the system would load offsets for ranges that no longer matched the new boundaries.Now the offset key includes
num-workers, so changing the worker count starts migration fresh instead of resuming with mismatched ranges.