Phase 2 · install-wide world-fact-cap tier (#100 carry-forward) - #101
Closed
nandanito wants to merge 1 commit into
Closed
Phase 2 · install-wide world-fact-cap tier (#100 carry-forward)#101nandanito wants to merge 1 commit into
nandanito wants to merge 1 commit into
Conversation
Fill the deferred middle tier of the world-fact cap: the install-wide default, mirroring the already-shipped three-tier recall budget (#60/PR #83). - `install_settings` gains a `world_fact_cap` column (additive, idempotent migration); `InstallSettingsRepository` gains get/set/clearWorldFactCap, each touching only its own column so the two install-wide defaults coexist. - `resolveWorldFactCap` is now three tiers: per-agent override ?? install-wide default ?? DEFAULT_WORLD_FACT_CAP. - Surfaced CLI-only (like the install-wide recall budget — no HTTP/console surface): `asterism config world-fact-cap --default <n>` (set/--unset/show), the per-agent verb now reports the install-wide default as the effective fallback, and `config show` gains the install-wide header + the `[install-wide default]` label. Help + docs updated. - Tests: install-settings world-fact-cap (set/clear/validate/coexistence), 3-tier resolveWorldFactCap precedence, and the CLI install-wide suite (replacing the old "not available yet" rejection test). Suite 1112 → 1123, tsc clean, verify:node + verify:deno 15/15. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #102 — the combined v0.4.0 release PR includes this commit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fills the deferred middle tier of the world-fact cap — the install-wide default — mirroring the already-shipped three-tier recall budget (#60 / PR #83). This is the small, unblocked carry-forward tracked in #100 (item 3).
Before:
resolveWorldFactCap = per-agent override ?? DEFAULT_WORLD_FACT_CAP(two tiers). After:per-agent override ?? install-wide default ?? DEFAULT_WORLD_FACT_CAP(three), exactly asresolveRecallBudgetalready layers its three.Changes
install_settingsgains aworld_fact_capcolumn (additive, idempotent migration; fresh DBs get it fromSCHEMA).InstallSettingsRepositorygainsgetWorldFactCap/setWorldFactCap/clearWorldFactCap, each touching only its own column so the two install-wide defaults (recall budget + world-fact cap) coexist on the single row.resolveWorldFactCapbecomes the full three-tier resolution.InstallSettingstype gainsworldFactCap?.asterism config world-fact-cap --default <n>— set /--default --unset/--defaultto show, dispatched the same way asrecall-budget --default(handles both--default 40and--default=40).install-wide defaultvsdefault) in its clear/show messages.config showgains anInstall-wide world-fact cap:header and the[install-wide default]per-agent label.help+docs/commands.mdupdated (incl. the previously-missing recall-budget--defaultsynopsis).Tests
install-settings.test.ts: world-fact-cap set/clear/validate + a coexistence test (the two install-wide defaults don't clobber each other).world-facts.test.ts: three-tierresolveWorldFactCapprecedence (per-agent > install-wide > constant, with fall-back on each clear).cli.test.ts: the install-wide world-fact-cap suite (set, inline--default=, show+clear, reject non-positive, precedence) — replaces the old "not available yet" rejection test.Suite 1112 → 1123,
tscclean,verify:node+verify:deno15/15. Verified end-to-end through the real CLI binary.Notes
install_settingsis the existing, deliberate narrow non-agent-scoped exception (it carries no agent data); per-agent caps stayagentId-scoped and still win. No change to the cap's semantics (loud write-rejection, never eviction).🤖 Generated with Claude Code