Skip to content

Runtime variant riscv32imaf_zve32f_zvfh_zba_zbb_ilp32f - #433

Merged
Pankaj Gode (pgodeq) merged 21 commits into
qualcomm:qualcomm-softwarefrom
pgodeq:qc-software-main-x160
Jul 13, 2026
Merged

Runtime variant riscv32imaf_zve32f_zvfh_zba_zbb_ilp32f#433
Pankaj Gode (pgodeq) merged 21 commits into
qualcomm:qualcomm-softwarefrom
pgodeq:qc-software-main-x160

Conversation

@pgodeq

Copy link
Copy Markdown
Contributor

No description provided.

"common": {
"TARGET_ARCH": "riscv32",
"VARIANT": "riscv32imaf_x160_ilp32f",
"COMPILE_FLAGS": "-mcpu=sifive-x160 -menable-experimental-extensions -mabi=ilp32f -fPIC",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ABI and PIC mode need to be confirmed with user first.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for CFI

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got confirmation from users to use -mabi=ilp32f and -fpic . They said no to CFI.
We got confirmation on the -march and qemu flags to use (had to add vlen=128, elen=32) as well.

This variant needed changes to picolibc, for enabling csr for vectors. The builds works with picolibc update.

@pgodeq
Pankaj Gode (pgodeq) force-pushed the qc-software-main-x160 branch 2 times, most recently from f5e6284 to f13d721 Compare June 29, 2026 13:00
@pgodeq Pankaj Gode (pgodeq) changed the title Runtime for SiFive X160 Runtime variant riscv32imaf_zve32f_zvfh_zba_zbb_ilp32f Jul 6, 2026
@pgodeq
Pankaj Gode (pgodeq) marked this pull request as ready for review July 7, 2026 12:14
Comment thread qualcomm-software/embedded-multilib/multilib.yaml.in Outdated
Comment thread qualcomm-software/test/multilib/riscv32.test
Comment thread qualcomm-software/scripts/build_linux_runtimes.sh
Comment thread qualcomm-software/scripts/build_linux_runtimes.sh Outdated
@pgodeq
Pankaj Gode (pgodeq) force-pushed the qc-software-main-x160 branch 7 times, most recently from f765b0e to 4bfa5b1 Compare July 10, 2026 22:28
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
@pgodeq
Pankaj Gode (pgodeq) force-pushed the qc-software-main-x160 branch 2 times, most recently from c083af1 to 1d84197 Compare July 10, 2026 22:50
@pgodeq

Pankaj Gode (pgodeq) commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks Sam and Jonathon for pushing the picolibc test change for zcmt/xqccmt.
This change-id issue took lot of time to resolve (). I hope the build succeeds here as well.

Comment thread qualcomm-software/embedded-multilib/json/multilib.json Outdated
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Pankaj Gode (@pgodeq)!

@lenary Sam Elliott (lenary) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgodeq
Pankaj Gode (pgodeq) merged commit 440bf27 into qualcomm:qualcomm-software Jul 13, 2026
13 checks passed
@pgodeq
Pankaj Gode (pgodeq) deleted the qc-software-main-x160 branch July 13, 2026 06:02
@cpullvmbot

Copy link
Copy Markdown
Collaborator

Failed to create pull request for issue433 https://github.com/qualcomm/cpullvm-toolchain/actions/runs/29492100857

@cpullvmbot

Copy link
Copy Markdown
Collaborator

Failed to create pull request for issue433 https://github.com/qualcomm/cpullvm-toolchain/actions/runs/29492313763

@cpullvmbot

Copy link
Copy Markdown
Collaborator

Failed to cherry-pick: release/22.x

https://github.com/qualcomm/cpullvm-toolchain/actions/runs/29492407401

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

Pankaj Gode (pgodeq) added a commit to pgodeq/cpullvm-toolchain that referenced this pull request Jul 16, 2026
Change-Id: I5871541ac9308627590781948139326d042b2cd2
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: Pankaj Gode <pgode@qti.qualcomm.com>
@lenary

Copy link
Copy Markdown
Member

Aren't we trying to cherry-pick to 22.x, not 23.x? The current milestone is 22.x, I think.

@jonathonpenix

Jonathon Penix (jonathonpenix) commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Also not sure if the comments requesting the cherry-pick were deleted or what, but from the one email I saw with a comment + based on the errors above, it looks like /cherry-pick or /cherry-pick <branch> is what was tried--the expected syntax is /cherry-pick <sha> (where is the sha of the commit to cherry-pick and the target branch is given by the milestone)

@cpullvmbot

Copy link
Copy Markdown
Collaborator

Failed to cherry-pick: `

https://github.com/qualcomm/cpullvm-toolchain/actions/runs/29524053896

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@cpullvmbot

Copy link
Copy Markdown
Collaborator

Failed to cherry-pick: `

https://github.com/qualcomm/cpullvm-toolchain/actions/runs/29524074697

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@cpullvmbot

Copy link
Copy Markdown
Collaborator

Failed to cherry-pick: `

https://github.com/qualcomm/cpullvm-toolchain/actions/runs/29524124135

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

@cpullvmbot

Copy link
Copy Markdown
Collaborator

Failed to cherry-pick: `

https://github.com/qualcomm/cpullvm-toolchain/actions/runs/29524296160

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

Pankaj Gode (pgodeq) added a commit to pgodeq/cpullvm-toolchain that referenced this pull request Jul 19, 2026
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Pankaj Gode (pgodeq) added a commit to pgodeq/cpullvm-toolchain that referenced this pull request Jul 19, 2026
Signed-off-by: “Pankaj <pgode@qti.qualcomm.com>
Signed-off-by: Pankaj Gode <pgode@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants