[Diagnostics] Emit mismatch diagnostics as notes with --no-warn-mismatch#1307
Open
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Open
[Diagnostics] Emit mismatch diagnostics as notes with --no-warn-mismatch#1307Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Conversation
Steven Ramirez Rosa (Steven6798)
requested review from
Parth (parth-07),
quic-areg and
Shankar Easwaran (quic-seaswara)
as code owners
Shankar Easwaran (quic-seaswara)
approved these changes
Jun 19, 2026
Diagnostics affected by --no-warn-mismatch (e.g., incompatible_architecture_versions) are no longer suppressed entirely. Instead, downgrade them to notes and always emit them, ensuring users have visibility into mismatch information without treating it as actionable warnings or errors. Fix: qualcomm#1264 Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
Steven Ramirez Rosa (Steven6798)
force-pushed
the
issue-1264
branch
from
cc64cb5 to
f64d4ed
Compare
Steven Ramirez Rosa (Steven6798)
requested a review
from Shakti Suman (quic-shaksuma)
|
|
||
| CHECK: Error: cannot recognize the format of file {{[` -\(\)_A-Za-z0-9.\\/:]+}}.3.o'. object format or given target machine ({{[` -\(\)_A-Za-z0-9.\\/:]+}}) is incompatible. | ||
| NOERR-NOT: Error: cannot recognize the format of file | ||
| NOERR: Note: cannot recognize the format of file {{.*}}'. object format or given target machine ({{.*}}) is incompatible. |
Contributor
There was a problem hiding this comment.
Shouldn't the link error out if we cannot read the input file?
Contributor
Author
There was a problem hiding this comment.
We are following GNU LD for the behavior of this flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostics affected by --no-warn-mismatch
(e.g., incompatible_architecture_versions) are no longer suppressed entirely.
Instead, downgrade them to notes and always emit them, ensuring users have visibility into mismatch information without treating it as actionable warnings or errors.
Fix: #1264