Unify default behavior for --warn-mismatch flags#1308
Merged
Steven Ramirez Rosa (Steven6798) merged 1 commit intoJun 26, 2026
Conversation
Steven Ramirez Rosa (Steven6798)
requested review from
Parth (parth-07),
quic-areg and
Shankar Easwaran (quic-seaswara)
as code owners
Parth (parth-07)
approved these changes
Jun 21, 2026
Steven Ramirez Rosa (Steven6798)
requested a review
from Shakti Suman (quic-shaksuma)
quic-areg
reviewed
Jun 26, 2026
quic-areg
left a comment
quic-areg
left a comment
Contributor
There was a problem hiding this comment.
Can you add a test? IIRC before this patch we would allow 32-bit and 64-bit objects to be merged without a warning on RISC-V and ARM, and that should no longer be the case.
LGTM otherwise
Steven Ramirez Rosa (Steven6798)
force-pushed
the
issue-1293
branch
from
a902183 to
6ad5f42
Compare
Shakti Suman (quic-shaksuma)
approved these changes
Jun 26, 2026
Contributor
Author
Sorry I completely missed your first comment. I'll update the patch |
Remove architecture-specific initialization of --[no-]warn-mismatch when not explicitly provided. Set the default behavior consistently to --warn-mismatch across all architectures. Fix: qualcomm#1293 Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
Steven Ramirez Rosa (Steven6798)
force-pushed
the
issue-1293
branch
from
6ad5f42 to
2910285
Compare
Contributor
Author
I updated the WrongArchInput test to include test cases without the --wan-mismatch flag. This should be enough to test the default behavior. Thanks for catching this. |
Steven Ramirez Rosa (Steven6798)
merged commit 51c8dcf
into
qualcomm:main
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove architecture-specific initialization of --[no-]warn-mismatch when not explicitly provided. Set the default behavior consistently to --warn-mismatch across all architectures.
Fix: #1293