[GNULDBackend] Replace std::move with std::copy in sizeDynNamePools#1318
Open
Saharsh Burra (bsaharsh) wants to merge 1 commit into
Open
[GNULDBackend] Replace std::move with std::copy in sizeDynNamePools#1318Saharsh Burra (bsaharsh) wants to merge 1 commit into
Saharsh Burra (bsaharsh) wants to merge 1 commit into
Conversation
Saharsh Burra (bsaharsh)
requested a review
from Shankar Easwaran (quic-seaswara)
as a code owner
Contributor
|
Saharsh Burra (@bsaharsh) Can you please make the clang-format builder happy, and add the 'Resolves #' in both the commit message and the PR description? |
std::move on a range of raw pointers (ResolveInfo *) is identical to std::copy — raw pointers are trivially copyable and moving them does not null the source. Using std::move here is misleading. Resolves qualcomm#1301 Signed-off-by: bsaharsh <bsaharsh@qti.qualcomm.com>
Saharsh Burra (bsaharsh)
force-pushed
the
fix/use-std-copy-in-sizeDynNamePools
branch
from
8781cb4 to
e98567e
Compare
Parth (parth-07)
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::move on a range of raw pointers (ResolveInfo *) is identical to std::copy — raw pointers are trivially copyable and moving them does not null the source. Using std::move here is misleading.
Resolves #1301 .