[RISCV] JVT Symbol Fixes#1331
Open
Sam Elliott (lenary) wants to merge 1 commit into
Open
Conversation
Sam Elliott (lenary)
requested a review
from Shankar Easwaran (quic-seaswara)
as a code owner
Member
Author
|
Marking as draft as the tests need more work. |
Sam Elliott (lenary)
force-pushed
the
pr/riscv-jvt-marker-symbol
branch
from
129ce1f to
13d6177
Compare
This PR includes two fixes to the Zcmt symbols: - It now updates the size of the `__jvt_base$` symbol to accurately reflect the size of the table it creates. - It adds a `$d` data mapping symbol so that when the jump table is put in an executable section (as is required), it is disassembled as data, not code. Signed-off-by: Sam Elliott <aelliott@qti.qualcomm.com>
Sam Elliott (lenary)
force-pushed
the
pr/riscv-jvt-marker-symbol
branch
from
13d6177 to
d8d4874
Compare
Sudharsan Veeravalli (svs-quic)
approved these changes
Jun 25, 2026
Sudharsan Veeravalli (svs-quic)
left a comment
Sudharsan Veeravalli (svs-quic)
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for doing this, Sam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two fixes to the Zcmt symbols:
__jvt_base$symbol to accurately reflect the size of the table it creates.$ddata mapping symbol so that when the jump table is put in an executable section (as is required), it is disassembled as data, not code.