Cherry-pick patches required for fixing the incorrect input section order within an output section issue#1333
Open
Parth (parth-07) wants to merge 4 commits into
Conversation
Parth (parth-07)
requested review from
quic-areg,
Shankar Easwaran (quic-seaswara) and
Sudharsan Veeravalli (svs-quic)
Parth (parth-07)
force-pushed
the
CherryPickIncorrectSortingIssue
branch
from
5b705d2 to
f3efe4e
Compare
This commit removes the unnecessary and incorrect sorting of input sections before the merge input sections phase when the LTO is enabled. Resolves qualcomm#1204 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
Parth (parth-07)
force-pushed
the
CherryPickIncorrectSortingIssue
branch
2 times, most recently
from
6e8e9e9 to
f8631c8
Compare
This commit adds the LinkerWrapper APIs sortInputSectionsForSectionMerging and getInputSectionsForSectionMerging. These APIs make it possible for plugins to change the order of the input sections, using a custom compare function, in a linker script rule and consequently in the output section. Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
This commit adds LinkerWrapper::getRuleMatchingInput API. This API returns the input-file that is used for linker script rule-matching for an input section. Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
This commit adds a new API, eld::plugin::InputFile::isLTOGeneratedObject, in the plugin framework. Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
Parth (parth-07)
force-pushed
the
CherryPickIncorrectSortingIssue
branch
from
f8631c8 to
d596423
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-pick patches that are required for fixing the incorrect input section order within an output section issue.