[AArch64] Fix regression in abs relocation#1334
Open
Cédric Tessier (nezetic) wants to merge 1 commit into
Open
[AArch64] Fix regression in abs relocation#1334Cédric Tessier (nezetic) wants to merge 1 commit into
Cédric Tessier (nezetic) wants to merge 1 commit into
Conversation
Signed-off-by: Cedric Tessier <ctessier@qti.qualcomm.com>
Cédric Tessier (nezetic)
requested a review
from Parth (parth-07)
as a code owner
Shankar Easwaran (quic-seaswara)
requested a review
from Eli Friedman (efriedma-quic)
Eli Friedman (efriedma-quic)
left a comment
Eli Friedman (efriedma-quic)
left a comment
Contributor
There was a problem hiding this comment.
The revised logic makes sense to me.
I think I'd reorganize the code a bit to keep the ptrauth relocations closer to the non-ptrauth counterparts. There are some weird inconsistencies, like rsym && rsym->isWeak() && rsym->isUndef() vs. rsym && rsym->isWeakUndef() && (pParent.config().codeGenType() == LinkerConfig::Exec).
I'd like to see testcases for absolute relocations against PLT symbols, and against weak undefined symbols, with and without ptrauth,
Shankar Easwaran (quic-seaswara)
left a comment
Shankar Easwaran (quic-seaswara)
left a comment
Contributor
There was a problem hiding this comment.
Can we accompany this with a build/run test ?
We have support for running tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a regression in aarch64 abs relocation.
The pauth path changed the original non-pauth logic, and this was never intended.