Report error when version script node has local block before the global - #1588
Open
Parth (parth-07) wants to merge 1 commit into
Open
Report error when version script node has local block before the global#1588Parth (parth-07) wants to merge 1 commit into
Parth (parth-07) wants to merge 1 commit into
Conversation
This commit updates ScriptParser to report error when a version script node contains local block before the global block. Resolves qualcomm#1582 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
Shankar Easwaran (quic-seaswara)
requested changes
Jul 28, 2026
|
|
||
| It is an error for a ``local:`` block to appear before a ``global:`` block in | ||
| the same version node. | ||
|
|
Contributor
There was a problem hiding this comment.
can we add a attention syntax here
.. attention::
Contributor
There was a problem hiding this comment.
is there any other kinds of errors that version script parser detects and silently errors out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates ScriptParser to report error when a version script node contains local block before the global block.
Resolves #1582