[Relocator] Show referenced symbol in overflow diagnostics - #1617
[Relocator] Show referenced symbol in overflow diagnostics#1617quic-areg wants to merge 1 commit into
Conversation
Parth (parth-07)
left a comment
Parth (parth-07)
left a comment
There was a problem hiding this comment.
Looks good to me, but it seems that some tests need to be updated to use the new diagnostic format.
6d2687a to
95eee31
Compare
Shankar Easwaran (quic-seaswara)
left a comment
Shankar Easwaran (quic-seaswara)
left a comment
There was a problem hiding this comment.
All of your changes look great, but I would like this change to be split into smaller pieces.
For this update, we only need the bare minimum required to show the input file. Any additional diagnostic enhancements can be submitted separately as follow-on improvements.
Also, please keep in mind that this change will need to be cherry-picked to 23.x as well. For 23.x we just need the bare minimum.
| /// True for the synthetic script input created for a --defsym assignment. | ||
| void setIsDefSym() { IsDefSym = true; } | ||
|
|
||
| bool isDefSym() const { return IsDefSym; } |
There was a problem hiding this comment.
This should be in a seperate commit.
| std::string ScriptCommand::getContextWithLineNumber() const { | ||
| return getContext() + (hasLineNumberInContext() | ||
| ? ":" + std::to_string(getLineNumberInContext()) | ||
| : ""); |
There was a problem hiding this comment.
We should seperate this to a seperate commit.
288160f to
5839073
Compare
Extend the relocation overflow error diagnostic to show the path and name for the referenced symbol. Fixes qualcomm#755 Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
5839073 to
617318e
Compare
|
Hi quic-areg, Is this PR good to merge from your side?
I think that the PR has underwent some changes and now some of these tasks are planned for follow up. Can you please update the commit message and the PR description? |
3 participants
Extend the relocation overflow error diagnostic to show the path and
name for the referenced symbol:
references ('sym') for an object-defined symbol
references <script>:('sym') for a linker script assignment or PROVIDE
references '--defsym sym' for a --defsym symbol
references linker internal symbol 'sym' for an internal symbol
Undefined and section symbols keep the old references 'sym' form.
Fixes #755