[ARM] Implement R_ARM_LDR_PC_G2 relocation - #1734
Draft
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Draft
[ARM] Implement R_ARM_LDR_PC_G2 relocation#1734Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Conversation
Steven Ramirez Rosa (Steven6798)
requested a review
from quic-areg
as a code owner
August 18, 2026 19:43
| .arm | ||
|
|
||
| .section .text.1, "ax", %progbits | ||
| .space 0x28 |
Contributor
There was a problem hiding this comment.
Do we need to use .space directive in this test?
Contributor
Author
There was a problem hiding this comment.
It is used to in the test to produce the value 0xfd8. Makes the testing easier. Let me know if there is a better and cleaner way to do this.
Add support for R_ARM_LDR_PC_G2 by sharing the ARM LDR PC-group residual encoding logic and wiring the relocation to the ARM apply table. The implementation extracts the signed LDR literal addend, computes S + A - P, selects the output U bit from the displacement sign, and writes the group residual into the imm12 field with overflow checking. Add standalone ARM relocation coverage for both a valid R_ARM_LDR_PC_G2 encoding and an overflow case where the group residual does not fit in imm12. Fix: qualcomm#1733 Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
Steven Ramirez Rosa (Steven6798)
force-pushed
the
issue-1733
branch
from
August 19, 2026 14:36
b696717 to
1b1d033
Compare
quic-areg
approved these changes
Aug 21, 2026
| @@ -0,0 +1,13 @@ | |||
| .arm | |||
Contributor
There was a problem hiding this comment.
This file looks identical to valid.s. Can we just use one copy?
Contributor
Author
There was a problem hiding this comment.
I missed that. Thanks!
Steven Ramirez Rosa (Steven6798)
marked this pull request as draft
August 21, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for R_ARM_LDR_PC_G2 by sharing the ARM LDR PC-group residual encoding logic and wiring the relocation to the ARM apply table. The implementation extracts the signed LDR literal addend, computes S + A - P, selects the output U bit from the displacement sign, and writes the group residual into the imm12 field with overflow checking.
Add standalone ARM relocation coverage for both a valid R_ARM_LDR_PC_G2 encoding and an overflow case where the group residual does not fit in imm12.
Fix: #1733