-
Notifications
You must be signed in to change notification settings - Fork 393
[deps] Pandoc 3.8.3, typst 0.14.2 #13249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
@tarleb It seems that there's a |
|
Sorry, I hadn't seen this. I'll try to be there today. |
|
@tarleb suggests |
On further thought, this only works if we know that the replacement for the shortcode is in a position where this escaping is required. In order to do that, we would have to enrich the LPEG parser to learn about parsing links and images, and then to process shortcodes differently inside links and images. That's a pretty large undertaking. |
|
I've pushed a fix: page inset needs to be typst raw inline. Most of the other failures seem to be because we need to update the Typst templates from Pandoc to get Skylighting support. Not trivial as there's a bunch of new stuff, but not that bad. |
|
Importing So all the stuff I need to update (merging Chris Kenny's improvements with brand yaml, basically) is not reflected in tests. TL;DR We've been applying Now syntax highlighting will match by default! Claude's explanation:Quarto always sets highlight-style for ALL formats, including typst:
Before pandoc 3.8/3.9: This didn't matter because pandoc ignored the highlight-style for typst and used typst's native highlighting. After pandoc 3.8/3.9: Pandoc now respects --syntax-highlighting for typst output, so quarto's default "arrow" style triggers skylighting for ALL code blocks, including unlanguaged ones (wrapped in NormalTok). What is
|
|
Thanks @gordonwoodhull! What I mentioned yesterday is also that Pandoc now uses
So I think we need to check if we use that flag, and probably anticipate the end of deprecation warning in our default file use.
The new option is now Currently we use And maybe in other places. Should we do this in another PR maybe ? It is kind of part of the pandoc update though. |
|
I am just updating to benefit from new condensed logging |
|
I think the biggest cause of failures right now if from a LaTeX change in how table counters work in the Pandoc writer and templates. I still don't understand how to avoid that problem. |
|
Oh, I have dealt with that recently for the rticles R package. I needed to add the missing template part to the rticles' built-in template (rstudio/rticles#596) They do something in the Writer that expects something in the template. It could be either this template addition, or some adaptation in the way we create the table. Also related, this change in Pandoc is for ensuring that unlabelled tables don't increment counter. I remember this was a problem in cross ref with counter workaround to decrement or something, so it could be now conflicting with what Pandoc is doing. Hope it helps understand. (Disclaimer: I did not look at failing examples, just what I looked for my rticles maintainance about this) |
The functions in engine-shared.ts (languagesInMarkdown, languagesInMarkdownFile, postProcessRestorePreservedHtml) have identical implementations in src/core/pandoc/pandoc-partition.ts and src/core/jupyter/preserve.ts. Update imports to use the canonical locations and remove the duplicate file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
for pandoc 3.8 next: investigate why this case enables syntax-highlighting
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
257f39a to
a540401
Compare
|
Pushed the typst template updates. |
…l command in Math Related to jgm/pandoc@27851bb
See addition in Pandoc for context jgm/pandoc@3a185fb
Related to jgm/pandoc@0cdb430 closes #13848
… now This needs to be integrated into Quarto by changing current support added in https://github.com/quarto-dev/quarto-cli/
|
I have done remaining update for template file, mostly beamer and LaTeX. I skipped revealjs as it will require a bit more work so this will be done later in #13852 I'll handle test failures next |
It will solve also
|
This new syntax is like the one in Quarto
````
: Here's the caption. {#ident .class key="value"}
````
So it needs some adaptation to work with our crossref system to avoid duplicate ids.
|
I confirm some of the problem may come from what I mentioned earlier at #13249 (comment) Tests failing because of this
Pandoc is now doing the following When no caption, pandoc will insert So we need to find a way to communicate to pandoc, or post process the tex file in some situations. As a reminder, this change in Pandoc was done so that uncaptionned longtable created by Pandoc don't increment the counter, which I think we are doing differently. quarto-cli/src/resources/filters/quarto-post/latex.lua Lines 302 to 311 in f33f44f
I am not sure what we do now... 🤔 maybe using
However, it seems longtable and latex has evolved since the counter problem so it may require some redesign. 🤷♂️ Update 08/01I finally found why we get bitten by that while we are handling caption usually. This happens because we do call
I have verified that all failing test goes through that part. This means we get the We could maybe remove the inserted latex when we process the raw table 🤔 quarto-cli/src/resources/filters/customnodes/floatreftarget.lua Lines 440 to 458 in ee3f232
|
Also refactor to not miss an update. This fix the failing test that was added to detect this version mismatch.
6adf07f to
2d33d1c
Compare
|
Among failing test, we have indeed the docusaurus change Previously and now I am trying to find what change about the newlines. It seems this is the
I can't find for sure if the syntax change is problematic for docusaurus math yet. If not, we could just fix the snapshot. UPDATE 07/01I see in pandoc 3.7, this line (Source: https://pandoc.org/releases.html#pandoc-3.7-2025-05-14) So maybe it could be linked... I notice this change in Panodc So this is why new line changed... but this is not with gfm. So side effect ? Looking more into this there is two problems: Pandoc change removing new linesI tested how Docusaurus (with remark-math + rehype-katex) renders display math with different formats. The breaking change:
Root cause: remark-math only recognizes HTML output difference: ... ... I used a test repo where I created minimal Docusaurus site with KaTeX to verify. Both Our Docusaurus format should use WebTeX by default!I opened an issue with the detail But in short
So the issue with new pandoc is mainly for UPDATEI opened an issue to pandoc as I am not sure this is really expected change for blocks like Display Math Right now, we'll need to post process to add new lines after UPDATE 08/01Pandoc has fixed the issue with the newline in math at jgm/pandoc#11384 So we could opt-out the test for now and reactivate for next Pandoc that will have the fix ? |
So we adapt the test
2d33d1c to
7535d71
Compare
- Show unified diff with colored lines and word-level changes with context instead of dumping full file contents - Use character diff for whitespace-only changes with visible markers (⏎ for newlines, → for tabs, · for spaces) - Save diff to .diff file on failure, clean up when snapshot passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- changed due to new quarto when running the test - changed due to formatting by VSCode
probably due to new docx reference doc or else in Pandoc new version
Add tests.run.skip field to allow unconditional test skipping with custom message. Skip docusaurus equations test until Pandoc fix for display math newlines is released (fixed in pandoc@8123be6).
Remaining Test Failures
Fixed by ee3f232
Tests: ./run-tests.sh docs/smoke-all/2023/04/11/format_underscores.qmd
./run-tests.sh docs/smoke-all/2023/05/01/5377.qmdThis is a new one because of 72452ee I did to try avoid the duplicate id problem but new
|
The unconditional disabling of table_attributes in 72452ee caused errors for formats like commonmark_x that don't support this extension. Pandoc 3.8.3+ validates all extension keys (both enabled and disabled) and rejects unsupported extensions. Use pandoc.format.all_extensions() to check if table_attributes is supported by the format before attempting to disable it.
Align Quarto's article() function with Pandoc's October 2024 fix (commit e01023c1f) for Typst 0.12+ two-column layout compatibility. Changes: - Replace columns(cols, doc) wrapper with plain doc return (page.typ already sets columns via set page(columns:)) - Change title block wrapper from block() to place(top, float: true, scope: "parent", clearance: 4mm) so title/authors/abstract span both columns - Remove unused cols parameter from typst-show.typ This fixes the error "page configuration is not allowed inside of containers" that occurred when using landscape sections with two-column layouts, since columns() creates a container that prevents set page() directives inside it. Add smoke tests for two-column typst layouts that verify: - Page columns set via set page(columns:) not columns() function - Title block wrapped with place(scope: "parent") for column spanning - Integration with landscape sections - Integration with table of contents - Full title block (title, subtitle, authors, abstract, thanks) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Pushed fixes and tests to address #13857 (comment) We were still calling the Typst Thanks @mcanouil for reporting this! |

Brings: