Skip to content

refactor: engine api adapter boundaries#2652

Draft
gvozdvmozgu wants to merge 51 commits into
mainfrom
refactor/engine-api-adapter-boundaries
Draft

refactor: engine api adapter boundaries#2652
gvozdvmozgu wants to merge 51 commits into
mainfrom
refactor/engine-api-adapter-boundaries

Conversation

@gvozdvmozgu

Copy link
Copy Markdown
Collaborator

No description provided.

@gvozdvmozgu

Copy link
Copy Markdown
Collaborator Author

Happy to split this PR into smaller ones once I’m done.

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for 3b6f6bc

Click to view benchmark
Test Base PR %
DepthMap::from_parent 62.2±1.14µs 60.8±0.67µs -2.25%
fix_complex_query 13.0±0.07ms 17.2±0.09ms +32.31%
fix_superlong 191.2±7.18ms 304.0±12.27ms +59.00%
parse_complex_query 4.2±0.06µs 4.2±0.03µs 0.00%
parse_expression_recursion 7.6±0.10µs 7.5±0.05µs -1.32%
parse_simple_query 1066.1±15.99ns 1043.3±13.87ns -2.14%

@gvozdvmozgu gvozdvmozgu force-pushed the refactor/engine-api-adapter-boundaries branch from 8d23e92 to eb7e32e Compare May 26, 2026 17:21
@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for cbbf9fc

Click to view benchmark
Test Base PR %
DepthMap::from_parent 35.9±0.50µs 35.5±0.72µs -1.11%
fix_complex_query 7.7±0.08ms 10.6±0.32ms +37.66%
fix_superlong 125.8±6.20ms 196.0±17.16ms +55.80%
parse_complex_query 2.8±0.04µs 2.8±0.03µs 0.00%
parse_expression_recursion 4.5±0.11µs 4.5±0.06µs 0.00%
parse_simple_query 606.7±9.33ns 600.0±8.62ns -1.10%

@gvozdvmozgu gvozdvmozgu force-pushed the refactor/engine-api-adapter-boundaries branch from 63b4ff3 to c1d1c3c Compare May 27, 2026 06:46
@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for 10b9853

Click to view benchmark
Test Base PR %
DepthMap::from_parent 54.1±0.74µs 53.7±1.52µs -0.74%
fix_complex_query 11.5±0.19ms 15.8±0.21ms +37.39%
fix_superlong 162.5±5.19ms 279.9±5.43ms +72.25%
parse_complex_query 4.4±0.06µs 4.5±0.07µs +2.27%
parse_expression_recursion 7.0±0.10µs 7.4±0.14µs +5.71%
parse_simple_query 974.5±19.35ns 962.5±12.22ns -1.23%

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for 180363b

Click to view benchmark
Test Base PR %
DepthMap::from_parent 58.0±1.73µs 63.5±0.96µs +9.48%
fix_complex_query 12.0±0.05ms 32.9±0.21ms +174.17%
fix_superlong 160.6±9.27ms 191.9±3.23ms +19.49%
parse_complex_query 4.2±0.08µs 4.1±0.04µs -2.38%
parse_expression_recursion 6.9±0.07µs 6.9±0.14µs 0.00%
parse_simple_query 1063.4±78.99ns 1046.5±11.79ns -1.59%

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for 9179bc1

Click to view benchmark
Test Base PR %
DepthMap::from_parent 57.5±0.80µs 57.5±0.55µs 0.00%
fix_complex_query 12.0±0.15ms 12.9±0.23ms +7.50%
fix_superlong 155.1±2.13ms 169.3±7.27ms +9.16%
parse_complex_query 4.3±0.23µs 4.1±0.05µs -4.65%
parse_expression_recursion 6.9±0.21µs 7.0±0.06µs +1.45%
parse_simple_query 1042.2±18.04ns 1062.9±16.33ns +1.99%

@gvozdvmozgu

Copy link
Copy Markdown
Collaborator Author

@benfdking Will you be available for review if I split it into smaller PRs? I’ve almost got the typed config working in the end -I just need to finish a few things.

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for 8ce25e3

Click to view benchmark
Test Base PR %
DepthMap::from_parent 61.6±1.32µs 60.6±0.37µs -1.62%
fix_complex_query 12.9±0.14ms 13.7±0.22ms +6.20%
fix_superlong 255.0±15.85ms 234.3±15.70ms -8.12%
parse_complex_query 4.2±0.05µs 4.4±0.06µs +4.76%
parse_expression_recursion 7.3±0.06µs 7.5±0.04µs +2.74%
parse_simple_query 1063.1±6.26ns 1074.3±13.33ns +1.05%

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for 373a1b7

Click to view benchmark
Test Base PR %
DepthMap::from_parent 59.4±0.82µs 58.2±1.76µs -2.02%
fix_complex_query 12.0±0.16ms 12.7±0.11ms +5.83%
fix_superlong 186.6±13.07ms 185.9±12.40ms -0.38%
parse_complex_query 4.2±0.20µs 4.1±0.06µs -2.38%
parse_expression_recursion 6.9±0.13µs 7.0±0.10µs +1.45%
parse_simple_query 1037.2±23.09ns 1043.5±19.56ns +0.61%

@benfdking

Copy link
Copy Markdown
Collaborator

Yep if we can break it up that would be great. Started working on it a little more again.

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark for 2bbbb4d

Click to view benchmark
Test Base PR %
DepthMap::from_parent 54.0±1.39µs 53.2±0.51µs -1.48%
fix_complex_query 11.8±0.07ms 12.6±0.10ms +6.78%
fix_superlong 199.3±9.90ms 222.8±14.10ms +11.79%
parse_complex_query 4.4±0.10µs 4.5±0.04µs +2.27%
parse_expression_recursion 7.0±0.15µs 7.1±0.12µs +1.43%
parse_simple_query 962.3±7.60ns 966.1±18.04ns +0.39%

@gvozdvmozgu

Copy link
Copy Markdown
Collaborator Author

@copilot rebase

Copilot AI commented May 31, 2026

Copy link
Copy Markdown
Contributor

@copilot rebase

I rebased this branch onto origin/main locally (HEAD 30d91747) and resolved conflicts. I can’t update the PR branch because the available push path is non-force and GitHub rejected the non-fast-forward update. Please force-push enablement or guidance on your preferred way to publish rebases from this environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants