Skip to content

refactor: config early cli migration#2872

Open
gvozdvmozgu wants to merge 9 commits into
mainfrom
config-early-cli-migration
Open

refactor: config early cli migration#2872
gvozdvmozgu wants to merge 9 commits into
mainfrom
config-early-cli-migration

Conversation

@gvozdvmozgu

@gvozdvmozgu gvozdvmozgu commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stacked PR 2/10: based on config-early-engine-foundation; review and merge after that PR.

  • Unify CLI lint and fix command execution through the shared runner.
  • Move reporting responsibilities out of sqruff-lib.
  • Fix follow-up fallout from the reporting split.

Testing

  • Validated with the full stacked branch:
  • cargo +1.96.1 fmt --check
  • cargo +1.96.1 check -p sqruff-lib -p sqruff-cli-lib -p sqruff-lsp
  • cargo +1.96.1 test -p sqruff --test none_format

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Benchmark for a7b2261

Click to view benchmark
Test Base PR %
DepthMap::from_parent 59.9±0.64µs 60.0±8.30µs +0.17%
fix_complex_query 12.1±0.15ms 12.2±0.04ms +0.83%
fix_superlong 125.3±5.42ms 123.9±3.01ms -1.12%
parse_complex_query 4.1±0.09µs 4.2±0.22µs +2.44%
parse_expression_recursion 6.7±0.10µs 6.9±0.08µs +2.99%
parse_simple_query 1077.4±77.96ns 1046.6±21.15ns -2.86%

@gvozdvmozgu gvozdvmozgu force-pushed the config-early-cli-migration branch from 181abe6 to 2f0ef29 Compare July 8, 2026 15:51
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Benchmark for d0e61a6

Click to view benchmark
Test Base PR %
DepthMap::from_parent 59.1±1.19µs 59.6±1.23µs +0.85%
fix_complex_query 12.3±0.06ms 12.1±0.16ms -1.63%
fix_superlong 134.0±8.68ms 132.8±8.56ms -0.90%
parse_complex_query 4.1±0.26µs 4.1±0.06µs 0.00%
parse_expression_recursion 7.2±0.09µs 6.9±0.09µs -4.17%
parse_simple_query 1050.3±34.36ns 1045.3±23.17ns -0.48%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant