Don't record own computor's duplicated invalid nonce.#813
Open
Don't record own computor's duplicated invalid nonce.#813
Conversation
Contributor
|
we should run the score again and continue the original flow if score is valid: there is (rare) chance that 2 solutions has the same flag. |
Collaborator
Author
|
We will delay this PR for next epoch, I will need to test to make sure it work as expectation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix unvalidated solutions recorded in system.solutions on duplicate submission.
In
processTickTransactionSolution, whenminerSolutionFlagsdetects a duplicate (publicKey, miningSeed, nonce), the else branch skips scoring but still records into system.solutions[] if the entry doesn't exist. This allows invalid solutions (rejected on first submission) to be recorded on second submission without any score check.This bug is limited to the node's own F2 display and solution publication,
minerScoresare unaffected.Fix: remove the unconditional add new entry block from the duplicate path. The existing dedup search and SOLUTION_RECORDED_FLAG marking for legitimate entries is preserved.