This repository was archived by the owner on Oct 19, 2023. It is now read-only.
Open
Conversation
also remove some unused args and hopefully make build working
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
** (CompileError) config/config.exs:55: undefined function config_env/0
** (CompileError) config/config.exs:55: undefined function config_env/0
(stdlib) lists.erl:1354: :lists.mapfoldl/3
(elixir) expanding macro: Kernel.if/2
config/config.exs:55: (file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hate it when software yells at me with yellow stuff >:D
MessageDispatcher.send_message and Dispatch.send_to_clients no longer take the sender as an arg as it's gone unused; removed redundant signature for queries that cannot be routed. (it seems it was a hacky thing anyways, as it was
nilmore often than a socket 🙄)hopefully I didn't screw up this time and the build will work ugh